open-notebook/frontend/src/lib/api/CLAUDE.md
Luis Novo 3f352cfcce
feat: credential-based API key management (#477) (#540)
* feat: replace provider config with credential-based system (#477)

Introduce a new credential management system replacing the old
ProviderConfig singleton and standalone Models page. Each credential
stores encrypted API keys and provider-specific configuration with
full CRUD support via a unified settings UI.

Backend:
- Add Credential domain model with encrypted API key storage
- Add credentials API router (CRUD, discovery, registration, testing)
- Add encryption utilities for secure key storage
- Add key_provider for DB-first env-var fallback provisioning
- Add connection tester and model discovery services
- Integrate ModelManager with credential-based config
- Add provider name normalization for Esperanto compatibility
- Add database migrations 11-12 for credential schema

Frontend:
- Rewrite settings/api-keys page with credential management UI
- Add model discovery dialog with search and custom model support
- Add compact default model assignments (primary/advanced layout)
- Add inline model testing and credential connection testing
- Add env-var migration banner
- Update navigation to unified settings page
- Remove standalone models page and old settings components

i18n:
- Update all 7 locale files with credential and model management keys

Closes #477

Co-Authored-By: JFMD <git@jfmd.us>
Co-Authored-By: OraCatQAQ <570768706@qq.com>

* fix: address PR #540 review comments

- Fix docs referencing removed Models page
- Fix error-handler returning raw messages instead of i18n keys
- Fix auth.py misleading docstring and missing no-password guard
- Fix connection_tester using wrong env var for openai_compatible
- Add provision_provider_keys before model discovery/sync
- Update CLAUDE.md to reflect credential-based system
- Fix missing closing brace in api-keys page useEffect

* fix: add logging to credential migration and surface errors in UI

- Add comprehensive logging to migrate-from-env and
  migrate-from-provider-config endpoints (start, per-provider
  progress, success/failure with stack traces, final summary)
- Fix frontend migration hooks ignoring errors array from response
- Show error toast when migration fails instead of "nothing to migrate"
- Invalidate status/envStatus queries after migration so banner updates

* docs: update CLAUDE.md files for credential system

Replace stale ProviderConfig and /api-keys/ references across 8 CLAUDE.md
files to reflect the new Credential-based system from PR #540.

* docs: update user documentation for credential-based system

Replace env var API key instructions with Settings UI credential
workflow across all user-facing documentation. The new flow is:
set OPEN_NOTEBOOK_ENCRYPTION_KEY → start services → add credential
in Settings UI → test → discover models → register.

- Rewrite ai-providers.md, api-configuration.md, environment-reference.md
- Update all quick-start guides and installation docs
- Update ollama.md, openai-compatible.md, local-tts/stt networking sections
- Update reverse-proxy.md, development-setup.md, security.md
- Fix broken links to non-existent docs/deployment/ paths
- Add credentials endpoints to api-reference.md
- Move all API key env vars to deprecated/legacy sections

* chore: bump version to 1.7.0-rc1

Release candidate for credential-based provider management system.

* fix: initialize provider before try block in test_credential

Prevents UnboundLocalError when Credential.get() throws (e.g.,
invalid credential_id) before provider is assigned.

* fix: reorder down migration to drop index before table

Removes duplicate REMOVE FIELD statement and reorders so the index
is dropped before the table, preventing rollback failures.

* refactor: simplify encryption key to always derive via SHA-256

Remove the dual code path in _ensure_fernet_key() that detected native
Fernet keys. Since the credential system is new, always deriving via
SHA-256 removes unnecessary complexity. Also removes the generate_key()
function and Fernet.generate_key() references from docs.

* fix: correct mock patch targets in embedding tests and URL validation

Fix embedding tests patching wrong module path for model_manager
(was targeting open_notebook.utils.embedding.model_manager but it's
imported locally from open_notebook.ai.models). Also fix URL validation
to allow unresolvable hostnames since they may be valid in the
deployment environment (e.g., Azure endpoints, internal DNS).

* feat: add global setup banner for encryption and migration status

Show a persistent banner in AppShell when encryption key is missing
(red) or env var API keys can be migrated (amber), so users see
these prompts on every page instead of only on Settings > API Keys.

Includes a docs link for the encryption banner and i18n support
across all 7 locales.

* docs: several improvements to docker-compose e env examples

* Update README.md

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

* docs: fix env var format in README and update model setup instructions

Align the encryption key snippet in README Step 2 with the list
format used in the compose file. Replace deprecated "Settings →
Models" instructions with credential-based Discover Models flow.

* fix: address credential system review issues

- Fix SSRF bypass via IPv4-mapped IPv6 addresses (::ffff:169.254.x.x)
- Fix TTS connection test missing config parameter
- Add Azure-specific model discovery using api-key auth header
- Add Vertex static model list for credential-based discovery
- Fix PROVIDER_DISCOVERY_FUNCTIONS incorrect azure/vertex mapping
- Extract business logic to api/credentials_service.py (service layer)
- Move credential Pydantic schemas to api/models.py
- Update tests to use new service imports and ValueError assertions

* fix: sanitize error responses and migrate key_provider to Credential

- Replace raw exception messages in all credential router 500 responses
  with generic error strings (internal details logged server-side only)
- Refactor key_provider.py to use Credential.get_by_provider() instead
  of deprecated ProviderConfig.get_instance()
- Remove unused functions (get_provider_configs, get_default_api_key,
  get_provider_config) that were dead code

---------

Co-authored-by: JFMD <git@jfmd.us>
Co-authored-by: OraCatQAQ <570768706@qq.com>
2026-02-10 08:30:22 -03:00

6.5 KiB

API Module

Axios-based client and resource-specific API modules for backend communication with auth, FormData handling, and error recovery.

Key Components

  • client.ts: Central Axios instance with request/response interceptors, auth headers, base URL resolution
  • Resource modules (sources.ts, notebooks.ts, chat.ts, search.ts, etc.): Endpoint-specific functions returning typed responses
  • query-client.ts: TanStack Query client configuration with default options
  • models.ts, notes.ts, embeddings.ts, settings.ts: Additional resource APIs

Important Patterns

  • Single axios instance: apiClient with 10-minute timeout (for slow LLM operations)
  • Request interceptor: Auto-fetches base URL from config, adds Bearer auth from localStorage auth-storage
  • FormData handling: Auto-removes Content-Type header for FormData to let browser set multipart boundary
  • Response interceptor: 401 clears auth and redirects to /login
  • Async base URL resolution: getApiUrl() fetches from runtime config on first request
  • Error propagation: All functions return typed responses via response.data
  • Method chaining: Resource modules export namespaced objects (e.g., sourcesApi.list(), sourcesApi.create())

Key Dependencies

  • axios: HTTP client library
  • @/lib/config: getApiUrl() for dynamic base URL
  • @/lib/types/api: TypeScript types for request/response shapes

How to Add New API Modules

  1. Create new file (e.g., transforms.ts)
  2. Import apiClient
  3. Export namespaced object with methods:
    export const transformsApi = {
      list: async () => { const response = await apiClient.get('/transforms'); return response.data }
    }
    
  4. Add types to @/lib/types/api if new response shapes needed

Important Quirks & Gotchas

  • Base URL delay: First request waits for getApiUrl() to resolve; can be slow on startup
  • FormData fields as JSON strings: Nested objects (arrays, objects) must be JSON stringified in FormData (e.g., notebooks, transformations)
  • Timeout for streaming: 10-minute timeout may not cover very long-running LLM operations; consider extending if needed
  • Auth token management: Token stored in localStorage auth-storage key; uses Zustand persist middleware
  • Headers mutation in interceptor: Mutating config.headers directly; be careful with middleware order
  • No retry logic: Failed requests not automatically retried; must be handled in consuming code
  • Content-Type header precedence: FormData interceptor deletes Content-Type after checking; subsequent interceptors won't re-add it

Usage Example

// Basic list
const sources = await sourcesApi.list({ notebook_id: notebookId })

// File upload with FormData
const response = await sourcesApi.create({
  type: 'upload',
  file: fileObj,
  notebook_id: notebookId,
  async_processing: true
})

// With auth token (auto-added by interceptor)
const notes = await notesApi.list()

Credentials Module (credentials.ts)

Client functions for managing AI provider credentials (API keys, base URLs, endpoints) stored encrypted in SurrealDB.

Type Definitions

// Full credential object (api_key never exposed)
interface Credential {
  id: string
  name: string
  provider: string
  modalities: string[]
  has_api_key: boolean
  model_count: number
  base_url?: string
  endpoint?: string
  api_version?: string
  // ... endpoint_llm, endpoint_embedding, endpoint_stt, endpoint_tts, project, location, credentials_path
}

// Request payload for creating/updating credential
interface CreateCredentialRequest {
  name: string
  provider: string
  modalities: string[]
  api_key?: string
  base_url?: string
  // ... other provider-specific fields
}

// Model discovery and registration
interface DiscoverModelsResponse { provider: string; models: DiscoveredModel[]; credential_id: string }
interface RegisterModelsRequest { models: RegisterModelData[] }

// Status and migration
interface CredentialStatus { configured: Record<string, boolean>; source: Record<string, string>; encryption_configured: boolean }
interface EnvStatus { [provider: string]: boolean }
interface MigrationResult { message: string; migrated: string[]; skipped: string[]; errors: string[] }
interface TestConnectionResult { provider: string; success: boolean; message: string }

API Functions

Function Description Endpoint
getStatus() Get configuration status of all providers GET /credentials/status
getEnvStatus() Get which providers have env vars set GET /credentials/env-status
list(provider?) List all credentials (optional filter) GET /credentials
listByProvider(provider) List credentials for a provider GET /credentials/by-provider/{provider}
get(credentialId) Get a specific credential GET /credentials/{credentialId}
create(data) Create a new credential POST /credentials
update(credentialId, data) Update a credential PUT /credentials/{credentialId}
delete(credentialId, options?) Delete a credential DELETE /credentials/{credentialId}
test(credentialId) Test connection using credential POST /credentials/{credentialId}/test
discover(credentialId) Discover available models POST /credentials/{credentialId}/discover
registerModels(credentialId, data) Register discovered models POST /credentials/{credentialId}/register-models
migrateFromProviderConfig() Migrate from legacy ProviderConfig POST /credentials/migrate-from-provider-config
migrateFromEnv() Migrate from env vars POST /credentials/migrate-from-env

Usage Example

import { credentialsApi } from '@/lib/api/credentials'

// Check which providers are configured
const status = await credentialsApi.getStatus()
if (status.configured['openai']) {
  console.log(`OpenAI configured via ${status.source['openai']}`)
}

// Create a new credential
const cred = await credentialsApi.create({
  name: 'My OpenAI Key',
  provider: 'openai',
  modalities: ['language', 'embedding'],
  api_key: 'sk-proj-...'
})

// Test the connection
const result = await credentialsApi.test(cred.id)
if (result.success) {
  console.log('Connection successful!')
}

// Discover and register models
const discovered = await credentialsApi.discover(cred.id)
await credentialsApi.registerModels(cred.id, {
  models: discovered.models.map(m => ({ model_id: m.model_id, name: m.name, type: 'language' }))
})